Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cmd/gno): re-use teststore in lint #3315

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat(cmd/gno): re-use teststore in lint #3315

wants to merge 4 commits into from

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Dec 10, 2024

continuing the work of #3119.

this PR makes gno lint re-use the same test.Store, speeding up execution (especially on the CI, which lints all packages) by not needing to load all packages for each package that is linted.

@github-actions github-actions bot added 📦 🤖 gnovm Issues or PRs gnovm related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Dec 10, 2024
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 10, 2024 •
edited
Loading

🛠 PR Checks Summary

🔴 The pull request head branch must be up-to-date with its base (more info)

Manual Checks (for Reviewers):
  • SKIP: Do not block the CI for this PR
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🔴 The pull request head branch must be up-to-date with its base (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: thehowl/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request
The pull request head branch must be up-to-date with its base (more info)

If

🟢 Condition met
└── 🟢 On every pull request

Then

🔴 Requirement not satisfied
└── 🔴 Head branch (thehowl:dev/morgan/fast-lint) is up to date with base (master): behind by 3 / ahead by 4
Manual Checks
**SKIP**: Do not block the CI for this PR

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@codecov Codecov
Copy link

codecov bot commented Dec 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 74.72527% with 23 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
gnovm/cmd/gno/lint.go 72.41% 6 Missing and 2 partials ⚠️
gnovm/pkg/gnomod/pkg.go 30.00% 5 Missing and 2 partials ⚠️
gnovm/pkg/packages/imports.go 81.81% 4 Missing ⚠️
gnovm/pkg/doc/dirs.go 57.14% 3 Missing ⚠️
gnovm/pkg/test/filetest.go 88.88% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@Kouteki Kouteki requested review from mvertes and gfanton December 11, 2024 12:43
@Kouteki Kouteki added the in focus Core team is prioritizing this work label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvertes mvertes Awaiting requested review from mvertes

@gfanton gfanton Awaiting requested review from gfanton

At least 1 approving review is required to merge this pull request.

Assignees

@thehowl thehowl

Labels
in focus Core team is prioritizing this work 📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related
Projects
🧙‍♂️gno.land core team
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thehowl @Gno2D2 @Kouteki